Update rdf-mapping.md doc #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for change made in: #1581 @seth-shaw-unlv
seth-shaw-unlv
suggested changes
Aug 20, 2020
|
I separated it into two sub-headings. does that improve readability? |
manez
reviewed
Aug 21, 2020
docs/islandora/rdf-mapping.md
Outdated
| - `mapping_type: rel` : [needs documentation] | ||
|
|
||
| #### Mapping Types | ||
| `mapping_type:`: There are several mapping types which are provided out of the box. One of those being `rel` - standing for relationship. The default, or if one is not provided is `property` meaning a property. |
There was a problem hiding this comment.
"The default, or if one is not provided is property meaning a property." I'm having a little bit of trouble parsing this line. Is "one" a relationship? If so, maybe:
"The default, or if a relationship is not provided, is property meaning a property."
There was a problem hiding this comment.
pushed another commit - is that any clearer?
manez
approved these changes
Aug 21, 2020
|
Hey @seth-shaw-unlv i used Github's "re-request review" because merging was blocked by your requested changes (huh!). Sorry for the multi-ping. |
seth-shaw-unlv
approved these changes
Aug 25, 2020
|
Sorry for the delay! I was out yesterday to help the kids with their first day back to school online. |
rosiel
pushed a commit
to rosiel/documentation
that referenced
this pull request
Sep 9, 2020
jordandukart
pushed a commit
that referenced
this pull request
Sep 9, 2020
dannylamb
pushed a commit
that referenced
this pull request
Sep 11, 2020
dannylamb
added a commit
that referenced
this pull request
Sep 16, 2020
…1598) * Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Mention the User Call (#1587) * Update rdf-mapping.md doc (#1585) * Update committers.md (#1592) * Document using base box and dev branch Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> Co-authored-by: dannylamb <dlamb@islandora.ca>
whikloj
pushed a commit
that referenced
this pull request
Sep 30, 2020
* Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Mention the User Call (#1587) * Update rdf-mapping.md doc (#1585) * Update committers.md (#1592) * Fix committer nomination email address (#1593) * Fix old email address. * Update closeCommitterVote.txt * De-CLAW * De-CLAW * DeCLAW * Change email * De-CLAW * Update travis for the main branch switch (#1594) * Master -> Main Rename * Remove comments about WebAC (#1555) * Remove comments about WebAC WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation. * Update user-intro.md * Add more details about starting up an islandora. (#1597) * Add more details about starting up an islandora. * Update index.md * Mention use of dev branch for prebuilt base box * Update index.md * Fix typo in VBE * Make clearer the different levels of sandbox reqs. * Update CONTRIBUTING.md (#1601) * Add Jordan to committers list (#1602) * Migration docs updates (#1603) * Added link to newer migration Youtube vid, added migration-overview.md * Replaced used of "*" with "-" for bulleted lists * Updated headings in docs and spelling changes * Main update (#1612) * Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Update rdf-mapping.md doc (#1585) Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> * Merge changes to add @manez to committers. (#1613) * Merge changes to add @manez to committers. * Alphabeticalize committer names. Co-authored-by: dannylamb <dlamb@islandora.ca> * De-CLAWing * Derp * Missing parenthesis Co-authored-by: Rosie Le Faive <lefaive@gmail.com> Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> Co-authored-by: Jonathan Green <jonathan.green@lyrasis.org> Co-authored-by: Don Richards <DonRichards@utk.edu> Co-authored-by: Melissa Anez <manez@islandora.ca> Co-authored-by: Yamil <ysuarez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / why
Add documentation for change made in: #1581
What changes were made?
Add documentation
Verification
Make sure the docs are clear.
Interested Parties
@Islandora/8-x-committers
@seth-shaw-unlv